Correct BIP-32 derivation issue #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well done! |
Roasbeef
requested changes
Oct 16, 2020
| copy(data[1:], k.key) | ||
| // Additionally, right align it if it's shorter than 32 bytes. | ||
| offset := 33 - len(k.key) | ||
| copy(data[offset:], k.key) |
There was a problem hiding this comment.
Rather than silently changing the behavior of this method, which can cause issues for any wallet that relies on this quirk as is (say when rescanning), I think we should instead break this method, and force callers to choose one or the other.
In other words: add a new variable to this method, and/or a helper func that assumes a new default value for this variable.
There was a problem hiding this comment.
renamed ChildNonStandard to DeriveNonStandard and Child to Derive. added a usage note
devrandom
force-pushed
the
bip32-zeros
branch
from
b10d526
to
dde9e31
Compare
|
cc @guggero |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #172.
This issue affects 1 in 256 hardened key derivations. For standard BIP-44 accounts, this affects the coin and account derivations, so 1 in 128 accounts will not be compatible with other BIP-44 implementations.
The intention is that wallet implementations using btcutil can use the
IsAffectedByIssue172call to check if they are affected, and potentially migrate (or ask the user to create a new wallet).